Switch MySQL tests to use dev services #51092
Conversation
quarkus-bot
bot
added
area/hibernate-orm
|
/cc @gsmet (hibernate-orm) |
Status for workflow
|
yrodiere
left a comment
yrodiere
left a comment
There was a problem hiding this comment.
Same as for the MariaDB PR: I'm a bit unsure about the optimizations we're losing, but otherwise LGTM!
| <description>Hibernate Reactive related tests running with the MySQL database and also using Agroal and Flyway</description> | ||
|
|
||
| <properties> | ||
| <reactive-mysql.url>vertx-reactive:mysql://localhost:3308/hibernate_orm_test?allowPublicKeyRetrieval=true</reactive-mysql.url> |
There was a problem hiding this comment.
I'm surprised that we're losing the allowPublicKeyRetrieval and not reintroducing it anywhere... was it pointless?
There was a problem hiding this comment.
There definitely were some bits of xml that as I deleted them, I thought "and something here will break" ... but nothing did. So I guess either maybe some tests got removed over time but their config hung around, or we want to cover those scenarios but don't have tests explicitly checking for them.
Not sure how best to handle without detailed analysis which I lack both appetite and expertise for!
| <!-- Speed things up a bit by not actually flushing writes to disk --> | ||
| <tmpfs>/var/lib/mysql</tmpfs> |
There was a problem hiding this comment.
Same comment as for the MariaDB PR:
| <volumes> | ||
| <bind> | ||
| <volume> | ||
| ${project.basedir}/custom-mariadbconfig:/etc/mysql/conf.d${volume.access.modifier} |
There was a problem hiding this comment.
Same comment as for the MariaDB PR: #51090 (comment)
2 participants
Partial resolution of #44124.